Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
side note, we only publicly expose
from_montgomery_limbs
in Fq, but not in Fp and Fr. Is this our intention?exposing
from_montgomery_limbs
andto_montgomery_limbs
in Fq is necessary for penumbra-zone/penumbra#3806 now that it's unblocked by #102.update: we're able to use the
from_bigint
andinto_bigint
arkworks methods instead. closing in favor of using that