Use commitment in NullfierStateDerivation proof #2833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For merging, we may not want to be modifying proof-related stuff quite at the moment, but this is a minor change. |
Just in the files I'm planning on changing here.
cronokirby
force-pushed
the
2764-nullifier-derivation-state-commitment
branch
from
8b81e94
to
5d8015b
Compare
This fixes a few places where we hadn't made this update yet.
Taking advantage of having touched this file to clean it up a bit.
1. Make note_commitment a public member of the struct. This seems to match other circuits, where the witnesses are private, and the public inputs are public. 2. Use position, not_commitment, nullifier_key, nullifier as the order. Previously, the order was inconsistent between prove / verify, and the other initialization methods. Making this consistent seemed like a good idea.
|
Looks like the CI failure here was unrelated to the diff in this PR and was resolved with #2838, so merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2764.
Previously, this proof would take in a public note, and compute the commitment in circuit. This PR changes the proof to take in the commitment directly, thus saving on constraints.