spec: small edits to typos in protocol docs #2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
commented
Jul 20, 2023
| @@ -40,9 +40,9 @@ using the above witnessed values and where `ds` is a constant domain separator: | |||
|
|
|||
| The zk-SNARK certifies that the public input fee commitment $cv_f$ was derived from the witnessed values as: | |||
|
|
|||
| $cv_f = [v_f] G_{v_f} + [\tilde v_f] G_{\tilde v}$ | |||
| $cv_f = [-v_f] G_{v_f} + [\widetilde{v_f}] G_{\widetilde{v}}$ | |||
There was a problem hiding this comment.
The value of the fee
|
@redshiftzero I just fixed docs build in 4c854ce, so CI will pass if you rebase on main. |
|
ah great thanks! |
redshiftzero
force-pushed
the
spec-feedback
branch
from
3f9a960
to
e2a9fb3
Compare
The original LaTeX works for me locally outside of mdbook, so I thought there must be an issue perhaps with mdbook-katex. I've replicated using the same version of mdbook-katex that CI is using that the `\tilde`s don't render, but the `\widetilde`s _do_ render, so I've switched to those across the protocol documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.