Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] decaf version bumps decaf #3678

Closed
wants to merge 9 commits into from

Conversation

TalDerei
Copy link
Collaborator

Experimenting with #3676

@TalDerei
Copy link
Collaborator Author

TalDerei commented Feb 2, 2024

continuing debugging proof failures

@TalDerei
Copy link
Collaborator Author

TalDerei commented Feb 5, 2024

Currently, proof verification is still failing. There are a few noteworthy observations to mention:

  • Old backend (v0.5) generates and verifies proofs with actual prover / verifier keys and dummy keys,
  • New backend (v0.8) generates and verifies proofs with dummy keys, but not with actual prover / verifier keys,
  • The representation of the dummy keys, for instance for a spend circuit, for some reason differs between v0.5 and v0.8.

Interestingly, in v0.8, the blinding factors, pk, and public and private inputs in spend_proof_parameters_vs_current_spend_circuit match up against the old backend, but proving generates a different proof result than expected and fails proof verification for spend proofs. Simply swapping the actual proving keys for the dummy keys succeeds.

As an aside, I generated a proof with v0.5, and verified the proof string directly in v0.8 which passes the verification checks with the actual verification key. This suggests there may be an issue instead with how we're serializing specifically our proving keys.

@redshiftzero I created a minimal crate called old-backend with calls to generate_constraint_matrices and generate_test_parameters which pass, which suggests our new backend is properly creating R1CS matrices.

@TalDerei TalDerei changed the title [DO NOT MERGE] decaf version bumps decaf version bumps Feb 7, 2024
@TalDerei TalDerei changed the title decaf version bumps [DO NOT MERGE] decaf version bumps decaf Feb 12, 2024
@TalDerei TalDerei mentioned this pull request Feb 12, 2024
1 task
@TalDerei
Copy link
Collaborator Author

Closing in favor of updated #3806

@TalDerei TalDerei closed this Feb 12, 2024
redshiftzero pushed a commit that referenced this pull request Jul 10, 2024
## Describe your changes
Updates the `decaf377`, `decaf377-rdsa`, and `poseidon377` dep versions 

## Issue ticket number and link
References #3676 and
consumes changes in #3678. unblocked by
penumbra-zone/decaf377#101

## Checklist before requesting a review
- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

---------

Co-authored-by: Lucas Meier <lucas@cronokirby.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant