Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade decaf377 deps #1481

Closed
TalDerei opened this issue Jul 16, 2024 · 0 comments
Closed

upgrade decaf377 deps #1481

TalDerei opened this issue Jul 16, 2024 · 0 comments
Assignees
Labels
deps update Update of project dependencies

Comments

@TalDerei
Copy link
Contributor

TalDerei commented Jul 16, 2024

so the original motivation for reworking the decaf377 crate was to eliminate our tightly coupled dependence on the Arkworks cryptography stack that’s used in our circuits. We redesigned the internal decaf377 API and generated our own formally verified code variants that we expected to be performant. Unfortunately, this led to some undesirable performance regressions for the proving time in the web, so we reverted some of that code. However, our changes were useful in enabling hardware wallet support on 32-bit targets (ledger).

tldr; the latest version of decaf377 doesn’t improve or degrade performance in the web, but the decaf377 crate dep should be bumped from 0.5.0 to 0.10.1 to maintain version parity with core.

@TalDerei TalDerei added the deps update Update of project dependencies label Jul 16, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Jul 16, 2024
@TalDerei TalDerei self-assigned this Jul 16, 2024
@TalDerei TalDerei moved this to 📝 Todo in Labs web Jul 16, 2024
@TalDerei TalDerei moved this from 📝 Todo to 🏗 In progress in Labs web Jul 16, 2024
@TalDerei TalDerei moved this from 🏗 In progress to 🛑 Blocked in Labs web Jul 19, 2024
@grod220 grod220 closed this as completed Aug 8, 2024
@github-project-automation github-project-automation bot moved this from 🗄️ Backlog to ✅ Done in Penumbra web Aug 8, 2024
@github-project-automation github-project-automation bot moved this from 🛑 Blocked to ✅ Done in Labs web Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps update Update of project dependencies
Projects
Archived in project
Development

No branches or pull requests

2 participants