Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc 0.2.0 #82

Merged
merged 3 commits into from
Mar 14, 2022
Merged

Rc 0.2.0 #82

merged 3 commits into from
Mar 14, 2022

Conversation

sam-bao
Copy link
Collaborator

@sam-bao sam-bao commented Mar 14, 2022

datimutils 0.2.0

Features

  • add getUserGroups
  • add listMechs
  • add getMyStreams
  • add getMyUserType

flopez-bao and others added 3 commits February 3, 2022 09:38
* add functions

added three new main functions for streams access, user classification and mechanism retrieval.

* vignette and tests

Added a vignette and an empty sample test file.

* Changes to getStreams process

-eliminated getStreams function and replaced with getUserGroups in getMetadataEndpoint.R which will give us what we need.

* Added new functions

Added - listMyMechs
Added - getMyStreams
Added - getMyUserType
Added - getUserGroups to getMetadataEndpoint

* Fixed magrittr import

Fixed magrittr import for listMyMechs and removed it from getMyStreams.

* Fixing PR issues

-Changed name of listMyMechs to listMechs
-Passed d2_session explicitly
-getUserType now calls getMyStreams
-Added getUserGroup to main vignette table
- UNIT TESTING still left

* Update Introduction-to-datimutils.Rmd

* fix vignette and getMyUserType

Made changes to fix vignette build and getMyUserType

* Update getMyUserType.Rd

update documentation.

* Update Securing-user-mechanism-access.Rmd

* Update listMechs.R

revert mech_code to code. Given the function purpose mech_ is not needed for clarity. We already leave it off of the name column

* Update Securing-user-mechanism-access.Rmd

update for change from mech_code to mech

Co-authored-by: sam-bao <sgarman@baosystems.com>
* add functions

added three new main functions for streams access, user classification and mechanism retrieval.

* vignette and tests

Added a vignette and an empty sample test file.

* Changes to getStreams process

-eliminated getStreams function and replaced with getUserGroups in getMetadataEndpoint.R which will give us what we need.

* Added new functions

Added - listMyMechs
Added - getMyStreams
Added - getMyUserType
Added - getUserGroups to getMetadataEndpoint

* Fixed magrittr import

Fixed magrittr import for listMyMechs and removed it from getMyStreams.

* Fixing PR issues

-Changed name of listMyMechs to listMechs
-Passed d2_session explicitly
-getUserType now calls getMyStreams
-Added getUserGroup to main vignette table
- UNIT TESTING still left

* Update Introduction-to-datimutils.Rmd

* fix vignette and getMyUserType

Made changes to fix vignette build and getMyUserType

* Update getMyUserType.Rd

update documentation.

* Update Securing-user-mechanism-access.Rmd

* Update listMechs.R

revert mech_code to code. Given the function purpose mech_ is not needed for clarity. We already leave it off of the name column

* Update Securing-user-mechanism-access.Rmd

update for change from mech_code to mech

* Change response

Changed stream response and modified user classification.

* Update listMechs.R

update column name for mech code.

* Testing

Added 100% coverage on unit tests for getMyStreams, getMyUserType and listMechs.

* Delete Securing-user-mechanism-access.Rmd

Get rid of vignette.

* Update helper.R

test build

* Update .gitignore

add .Rprofile to gitignore

* Remove .Rprofile

.Rprofile was not in .gitignore. Added to .gitignore. Made tests backward compatible with 3.6.3. Should also hold up with >4.

* Added description link

Added description link for implementation.

* Fixed vignette issue

Removed vignette.

* fixed test issues

devtools::check now passes as well as devtools::test.

* Update DESCRIPTION

* Create NEWS.md

* Update DESCRIPTION

* Final Checks

- moved helper user group list to each test
- renamed uid_list to user group list
- documented test for list mechs

Co-authored-by: sam-bao <sgarman@baosystems.com>
@sam-bao sam-bao merged commit 17819c9 into master Mar 14, 2022
@sam-bao sam-bao deleted the RC-0.2.0 branch March 14, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants