Contributed fixes from bugs #1510085 and #1510092 #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
george-lorch
pushed a commit
that referenced
this pull request
Nov 16, 2015
Contributed fixes from bugs #1510085 and #1510092
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUGS:
storage/tokudb/PerconaFT/buildheader/CMakeLists.txt - https://bugs.launchpad.net/percona-server/+bug/1510085
tokudb differences when merging with MariaDB - https://bugs.launchpad.net/percona-server/+bug/1510092
TEST BUILD:
param build:
http://jenkins.percona.com/job/percona-server-5.6-param/1020/
release build:
http://jenkins.percona.com/job/percona-server-5.6-RELEASE/47/
LINKED PR:
percona/percona-server#231
NOTICE:
Not resolved right now in bug #1510092:
#4 (first thing only):
In PS it's not used but in Percona Server for MongoDB it's used in some way so need to check how it plays with other projects.
#8:
ZLIB_LIBRARY is not defined in Percona Server for MongoDB so same as above.
#10 (second thing only):
Percona Server for MongoDB has different setup so we probably don't want to change this right now.
Opened: BLD-361 in Jira for checking these three unmerged stuff.