PS-5223 : Can't upgrade with encrypted undo tablespaces from 5.7.24 to #3119
Conversation
| --copy_file $MYSQLTEST_VARDIR/std_data/undo57_encrypted.zip $MYSQL_TMP_DIR/undo57_encrypted.zip | ||
|
|
||
| --echo # Check that the file exists in the working folder. | ||
| --file_exists $MYSQL_TMP_DIR/undo57_encrypted.zip |
There was a problem hiding this comment.
Redundant, let either copy_file, either exec unzip fail
|
|
||
| --source include/shutdown_mysqld.inc | ||
|
|
||
| --echo # Now lets test what happens when encryption key is missing and we try to start 8.0 server on 5.7 directory |
There was a problem hiding this comment.
| --echo # Now lets test what happens when encryption key is missing and we try to start 8.0 server on 5.7 directory | |
| --echo # Now let's test what happens when encryption key is missing and we try to start 8.0 server on 5.7 directory |
| --echo # Check that the file exists in the working folder. | ||
| --file_exists $MYSQL_TMP_DIR/undo57_encrypted.zip | ||
|
|
||
| --echo # Unzip the zip file. |
There was a problem hiding this comment.
Too obvious comment
| --echo # Unzip the zip file. |
| --echo # Recreate the directories | ||
| --force-rmdir $MYSQL_TMP_DIR/undo57_encrypted | ||
| --echo # Check that the file exists in the working folder. | ||
| --file_exists $MYSQL_TMP_DIR/undo57_encrypted.zip |
There was a problem hiding this comment.
I cannot remove the --force-rmdir part as there are some leftovers and server refuses to start:
2019-04-05T16:27:38.197914Z 1 [ERROR] [MY-012209] [InnoDB] Multiple files found for the same tablespace ID:
2019-04-05T16:27:38.197938Z 1 [ERROR] [MY-012202] [InnoDB] Tablespace ID: 15 = ['mysql/innodb_table_stats.ibd', 'mysql/innodb_table_stats_backup57.ibd']
2019-04-05T16:27:38.197955Z 1 [ERROR] [MY-012202] [InnoDB] Tablespace ID: 16 = ['mysql/innodb_index_stats.ibd', 'mysql/innodb_index_stats_backup57.ibd']
There was a problem hiding this comment.
No remove not the force-rmdir but file_exists line
There was a problem hiding this comment.
ack, this was done
| --echo # Check that the file exists in the working folder. | ||
| --file_exists $MYSQL_TMP_DIR/undo57_encrypted.zip | ||
|
|
||
| --echo # Unzip the zip file. |
There was a problem hiding this comment.
| --echo # Unzip the zip file. |
robgolebiowski
force-pushed
the
8_0_PS-5223_upgrade_encrypted_undo
branch
from
e9607b7
to
d2cf60b
Compare
8.0.13 This is a fix for upgrade from 5.7 encrypted undo tablespaces to PS 8.0.15. The fix is to accept encrypted undo tablespace header with ENCRYPTION_KEY_MAGIC_V2 (instead of only ENCRYPTION_KEY_MAGIC_V3), since PS 5.7 encrypted undo tablespaces are encrypted with ENCRYPTION_KEY_MAGIC_V2. Testcase percona_dd_upgrade_undo_encrypted was addded. It tests upgrade with 5.7 encrypted undo tablespaces with: 1) correct keyring and later upgrade 2) empty keyring 3) corrupted undo encryption keys
robgolebiowski
force-pushed
the
8_0_PS-5223_upgrade_encrypted_undo
branch
from
d2cf60b
to
dfa6769
Compare
|
@satya-bodapati @laurynas-biveinis @dutow ready for review |
8.0.13
This is a fix for upgrade from 5.7 encrypted undo tablespaces to PS
8.0.15. The fix is to accept encrypted undo tablespace header with
ENCRYPTION_KEY_MAGIC_V2 (instead of only ENCRYPTION_KEY_MAGIC_V3),
since PS 5.7 encrypted undo tablespaces are encrypted with
ENCRYPTION_KEY_MAGIC_V2.
Testcase percona_dd_upgrade_undo_encrypted was addded. It tests
upgrade with 5.7 encrypted undo tablespaces with: