PS-5883 feature 8.0: Port MariaDB arm64 performance improvements #4851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storage/innobase/include/sync0rw.ic
Outdated
| @@ -85,7 +85,7 @@ static inline void rw_lock_reset_waiter_flag( | |||
| rw_lock_t *lock) /*!< in/out: rw-lock */ | |||
| { | |||
| bool one = true; | |||
| lock->waiters.compare_exchange_strong(one, false); | |||
| lock->waiters.compare_exchange_strong(one, false, std::memory_order_relaxed); | |||
There was a problem hiding this comment.
Why not a store(false, std::memory_order_relaxed)? Likewise one above
There was a problem hiding this comment.
Blind copy-pasting.
Fixed
https://jira.percona.com/browse/PS-5883 Ported "rw_lock" ARM64 memory barriers patches from MariaDB Server. MDEV-14529 "InnoDB rw-locks: optimize memory barriers" (https://jira.mariadb.org/browse/MDEV-14529) (commit MariaDB/server@b04f2a0f019) (commit MariaDB/server@51bb18f989d) (commit MariaDB/server@5b624f00fc0) (commit MariaDB/server@57d20f1132d) (commit MariaDB/server@c73e77da0fa)
percona-ysorokin
force-pushed
the
dev/PS-5883-8.0-arm_rw_lock_relaxed
branch
from
a0a2cb7
to
cfa6172
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.percona.com/browse/PS-5883
Ported "rw_lock" ARM64 memory barriers patches from MariaDB Server.
MDEV-14529 "InnoDB rw-locks: optimize memory barriers"
(https://jira.mariadb.org/browse/MDEV-14529)
(commit MariaDB/server@b04f2a0f019)
(commit MariaDB/server@51bb18f989d)
(commit MariaDB/server@5b624f00fc0)
(commit MariaDB/server@57d20f1132d)
(commit MariaDB/server@c73e77da0fa)