-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.7.44-49 #5260
Merged
Merged
Release 5.7.44-49 #5260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://perconadev.atlassian.net/browse/PS-9048 Fixed problem with 'fts_index_fetch_nodes()' function not being able to properly handle situations when 'word' parameter contained special characters used by 'LIKE' clauses ('%' and '_'). Introduced additional boolean parameter 'exact_match' that instructs this function to use either 'WHERE word = :word' or 'WHERE word LIKE :word' clauses when selecting records from internal FTS tables. We call 'fts_index_fetch_nodes()' with 'exact_match' set to 'true' only from 'fts_optimize_words()' (when we perform 'OPTIMIZE TABLE' under 'innodb_optimize_fulltext_only' enabled). In every other place * fts_query_difference() * fts_query_intersect() * fts_query_union() * fts_query_phrase_search() where we indeed need pattern matching we call this function with 'exact_match' set to 'false' (instructing the function to use the 'LIKE' clause). Added six new MTR test cases: * 'innodb_fts.percona_ft_special_chars_default_ewc_on' * 'innodb_fts.percona_ft_special_chars_default_ewc_off' * 'innodb_fts.percona_ft_special_chars_ngram_ewc_on' * 'innodb_fts.percona_ft_special_chars_ngram_ewc_off' * 'innodb_fts.percona_ft_special_chars_mecab_ewc_on' * 'innodb_fts.percona_ft_special_chars_mecab_ewc_off' which reproduce original crash scenario using default / ngram / mecab parsers, under both 'ft_query_extra_word_chars' set to 'ON' and 'OFF'. These tests cases also check parsing / querying strings containing various special characters. Please note that they have "result mismatch" status strings recorded in the '.result' files for certain combinations of special characters and this is expected behavior. Introduced two new MTR helper '.inc' files: * percona_install_mecab_plugin.inc * percona_uninstall_mecab_plugin.inc which help install / uninstall the mecab plugin along with creating / removing its settings file. 'innodb_fts.percona_mecab_null_character' MTR test case reworked with these two include files.
…t_ngram PS-9048 fix 5.7: Fixed problem with percent character in n-grams
https://perconadev.atlassian.net/browse/PS-9096 Raised MYSQL_VERSION_EXTRA to 49 in MYSQL_VERSION file. Raised PERCONA_INNODB_VERSION to 49 in univ.i file.
PS-9096 Update the versions numbers
PKG-14 Rework 5.7 tarballs
PS-9133 Telemetry metrics show wrong version
VarunNagaraju
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.