Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS-9188 [trunk]: Add clang-18 to Azure Pipelines #5286

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

inikep
Copy link
Collaborator

@inikep inikep commented Apr 17, 2024

  1. Add clang-18 to Azure Pipelines
  2. Introduce BUILD_PARAMS_TYPE in azure-pipelines.yml (ported from fb-mysql-8.0.36)
  3. Fix clang-18 compilation issues

1. Boost issues:
```
In file included from /data/mysql-server/percona-8.0/sql/gis/line_interpolate.cc:29:
In file included from /data/mysql-server/_deps/boost_1_77_0/boost/geometry.hpp:17:
In file included from /data/mysql-server/_deps/boost_1_77_0/boost/geometry/geometry.hpp:53:
In file included from /data/mysql-server/_deps/boost_1_77_0/boost/geometry/core/radian_access.hpp:26:
In file included from /data/mysql-server/_deps/boost_1_77_0/boost/numeric/conversion/cast.hpp:33:
In file included from /data/mysql-server/_deps/boost_1_77_0/boost/numeric/conversion/converter.hpp:13:
In file included from /data/mysql-server/_deps/boost_1_77_0/boost/numeric/conversion/conversion_traits.hpp:13:
In file included from /data/mysql-server/_deps/boost_1_77_0/boost/numeric/conversion/detail/conversion_traits.hpp:18:
In file included from /data/mysql-server/_deps/boost_1_77_0/boost/numeric/conversion/detail/int_float_mixture.hpp:19:
In file included from /data/mysql-server/_deps/boost_1_77_0/boost/mpl/integral_c.hpp:32:
/data/mysql-server/_deps/boost_1_77_0/boost/mpl/aux_/integral_wrapper.hpp:73:31: error: integer value -1 is outside the valid range of values [0, 3] for the enumeration type 'udt_builtin_mixture_enum' [-Wenum-constexpr-conversion]
   73 |     typedef AUX_WRAPPER_INST( BOOST_MPL_AUX_STATIC_CAST(AUX_WRAPPER_VALUE_TYPE, (value - 1)) ) prior;
      |                               ^
/data/mysql-server/_deps/boost_1_77_0/boost/mpl/aux_/static_cast.hpp:24:47: note: expanded from macro 'BOOST_MPL_AUX_STATIC_CAST'
   24 | #   define BOOST_MPL_AUX_STATIC_CAST(T, expr) static_cast<T>(expr)
      |
```

2. Issues with stdc++ library from gcc-13:

```
In file included from /data/mysql-server/percona-8.0/libbinlogevents/src/compression/none_comp.cpp:23:
In file included from /data/mysql-server/percona-8.0/libbinlogevents/include/compression/none_comp.h:26:
In file included from /data/mysql-server/percona-8.0/libbinlogevents/include/compression/compressor.h:27:
In file included from /data/mysql-server/percona-8.0/libbinlogevents/include/compression/base.h:26:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/string:54:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/basic_string.h:39:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/ext/alloc_traits.h:34:
/usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/alloc_traits.h:266:8: error: 'construct<mysqlns::buffer::Buffer_view<>, mysqlns::buffer::Buffer_view<>>' is deprecated: std::allocator::construct is deprecated in C++17 [-Werror,-Wdeprecated-declarations]
  266 |         { __a.construct(__p, std::forward<_Args>(__args)...); }
      |               ^
/data/mysql-server/percona-8.0/libbinlogevents/include/resource/allocator.h:139:5: note: 'construct<mysqlns::buffer::Buffer_view<>, mysqlns::buffer::Buffer_view<>>' has been explicitly marked deprecated here
  139 |   [[deprecated("std::allocator::construct is deprecated in C++17")]] void
      |     ^
```
Copy link
Collaborator

@percona-ysorokin percona-ysorokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inikep inikep merged commit 4e75783 into percona:trunk Apr 18, 2024
8 of 23 checks passed
@inikep inikep deleted the PS-9188-trunk branch April 18, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants