PS-8963 fix 8.0: SEQUENCE_TABLE Issue #5336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://perconadev.atlassian.net/browse/PS-8963 Introduced new 'PERCONA_SEQUENCE_TABLE' reserved keyword which is supposed to be a safe replacement for 'SEQUENCE_TABLE' which is now considered to be deprecated. Currently both have identical behavior except the fact that the latter now generates a deprecation warning. As an intermediate step before deprecated 'SEQUENCE_TABLE' is removed the MySQL parser has been modified so that 'SEQUENCE_TABLE' is no longer a reserved keyword and can now be used as a regular MySQL identifier (table name, column name, alias name, etc). 'SEQUENCE_TABLE' token added to the list of the non-reserved keywords ('<ident_keywords_unambiguous>') in the Percona Server grammar file ('sql_yacc.yy'). Added new 'main.percona_sequence_table_keyword' MTR test case that check various scenarios of 'SEQUENCE_TABLE' used as a simple table name, as an alias, or a table function. Re-recorded 'main.information_schema_keywords' MTR test case because 'SEQUENCE_TABLE' is no longer a reserved keyword. Updated a number of existing MTR test cases with new 'PERCONA_SEQUENCE_TABLE()' table-level function instead of 'SEQUENCE_TABLE()'.
percona-ysorokin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PS-8963
Introduced new 'PERCONA_SEQUENCE_TABLE' reserved keyword which is supposed to be a safe replacement for 'SEQUENCE_TABLE' which is now considered to be deprecated.
Currently both have identical behavior except the fact that the latter now generates a deprecation warning.
As an intermediate step before deprecated 'SEQUENCE_TABLE' is removed the MySQL parser has been modified so that 'SEQUENCE_TABLE' is no longer a reserved keyword and can now be used as a regular MySQL identifier (table name, column name, alias name, etc).
'SEQUENCE_TABLE' token added to the list of the non-reserved keywords ('<ident_keywords_unambiguous>') in the Percona Server grammar file ('sql_yacc.yy').
Added new 'main.percona_sequence_table_keyword' MTR test case that check various scenarios of 'SEQUENCE_TABLE' used as a simple table name, as an alias, or a table function.
Re-recorded 'main.information_schema_keywords' MTR test case because 'SEQUENCE_TABLE' is no longer a reserved keyword.
Updated a number of existing MTR test cases with new 'PERCONA_SEQUENCE_TABLE()' table-level function instead of 'SEQUENCE_TABLE()'.