PS-9218 merge: Merge MySQL 8.4.0 (MTR test fixes) #5355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://perconadev.atlassian.net/browse/PS-9218 - removed enable/disable_reconnect - fixed path to included files ('extra/' -> 'common/') - removed 'rocksdb.upgrade_parts_from_prev_ver' test, it checked upgrades from previous (non-native) partitioning format in 5.7 - updated rocksdb_rpl.rpl_rocksdb_stm_mixed_auto_increment and rocksdb_rpl.rpl_rocksdb_row_auto_increment tests to use rpl_auto_increment_innodb.test internally as rpl_auto_increment.test is now deleted - updated and renamed rocksdb_rpl.rpl_rocksdb_extra_col_slave and rocksdb_rpl.rpl_rocksdb_extra_col_master tests - deprecated LOW_PRIORITY WRITE changed to WRITE in rocksdb.lock - removed ENGINE=xxx from DROP TABLESPACE statement in rocksdb.create_table - re-record innodb.log_encrypt_kill test - updated percona.utility_user test to mask thread ID in ER_KILL_DENIED_ERROR error string - in rocksdb.autoinc_vars removed checks for DOUBLE AUTO_INCREMENT as support for it was removed in this release - in rocksdb_rpl.rpl_rocksdb_row_img_idx_full, rocksdb_rpl.rpl_rocksdb_row_img_idx_min and rocksdb_rpl.rpl_rocksdb_row_img_idx_noblob binlog_transaction_dependency_tracking=COMMIT_ORDER changed to binlog_transaction_dependency_history_size=1 as COMMIT_ORDER was removed by upstream.
…connection_configuration [Post fix] Fixing test rpl_log_info_repository_persistence_require_row that was not accounting for the group replication recovery channel that is now shown when configured. Change-Id: I514e8f03536d928f884505cca7be130fe8285b4d
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -6,7 +6,7 @@ | |||
| --connection master | |||
| --let $master_host = 127.0.0.1 | |||
|
|
|||
| CREATE USER 'rocksdb_stress_test'@'localhost' IDENTIFIED WITH 'mysql_native_password'; | |||
| CREATE USER 'rocksdb_stress_test'@'localhost' IDENTIFIED WITH 'caching_sha2_password'; | |||
| GRANT ALL ON *.* TO 'rocksdb_stress_test'@'localhost'; | |||
There was a problem hiding this comment.
unknown type name GRANT
| @@ -6,7 +6,7 @@ | |||
| --connection master | |||
| --let $master_host = 127.0.0.1 | |||
|
|
|||
| CREATE USER 'rocksdb_stress_test'@'localhost' IDENTIFIED WITH 'mysql_native_password'; | |||
| CREATE USER 'rocksdb_stress_test'@'localhost' IDENTIFIED WITH 'caching_sha2_password'; | |||
| GRANT ALL ON *.* TO 'rocksdb_stress_test'@'localhost'; | |||
There was a problem hiding this comment.
expected ; after top level declarator
Suggested change
| GRANT ALL ON *.* TO 'rocksdb_stress_test'@'localhost'; | |
| GRANT ALL; ON *.* TO 'rocksdb_stress_test'@'localhost'; |
| @@ -6,7 +6,7 @@ | |||
| --connection master | |||
| --let $master_host = 127.0.0.1 | |||
|
|
|||
| CREATE USER 'rocksdb_stress_test'@'localhost' IDENTIFIED WITH 'mysql_native_password'; | |||
| CREATE USER 'rocksdb_stress_test'@'localhost' IDENTIFIED WITH 'caching_sha2_password'; | |||
| GRANT ALL ON *.* TO 'rocksdb_stress_test'@'localhost'; | |||
|
|
|||
| let $exec = | |||
There was a problem hiding this comment.
unknown type name let
| @@ -21,7 +21,6 @@ | |||
|
|
|||
| --exec rm $MYSQL_TMP_DIR/load_generator.log | |||
There was a problem hiding this comment.
expected unqualified-id
| @@ -21,7 +21,6 @@ | |||
|
|
|||
| --exec rm $MYSQL_TMP_DIR/load_generator.log | |||
|
|
|||
| enable_reconnect; | |||
| source include/wait_until_connected_again.inc; | |||
|
|
|||
| --let $master_checksum = query_get_value(CHECKSUM TABLE $table, Checksum, 1) | |||
There was a problem hiding this comment.
expected unqualified-id
percona-ysorokin
merged commit a81167e
into
percona:release-8.4.0-1
9 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PS-9218