Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS-9314 fix: Signal 11 when using JSON_TABLE #5368

Conversation

percona-ysorokin
Copy link
Collaborator

@percona-ysorokin percona-ysorokin commented Aug 2, 2024

https://perconadev.atlassian.net/browse/PS-9314

As part of the 8.0.22 merge we added our fix (commit e29ddfe) for Oracle's Bug #101401
"ISNULL continously returns the same value for LOAD_FILE" (https://bugs.mysql.com/bug.php?id=101401)
However, when Oracle fixed the same issue in 8.0.23, Bug #32096341
"ISNULL continuously returns the same value for LOAD_FILE" (commit mysql/mysql-server@de4b3f7), our fix never got reverted, which introduced this regression.

Fixed by reverting our patch.

Extended 'main.func_str' MTR test case with additional checks for this particular regression.

https://perconadev.atlassian.net/browse/PS-9314

As part of the 8.0.22 merge we added our fix (commit e29ddfe) for
Oracle's Bug #101401
"ISNULL continously returns the same value for LOAD_FILE"
(https://bugs.mysql.com/bug.php?id=101401)
However, when Oracle fixed the same issue in 8.0.23,
Bug #32096341
"ISNULL continuously returns the same value for LOAD_FILE"
(commit mysql/mysql-server@de4b3f7), ou fix never got reverted,
which introduced this regression.

Fixed by reverting our patch.

Extended 'main.func_str' MTR test case with additional checks for this
particular regression.
@percona-ysorokin
Copy link
Collaborator Author

This PR is created on top of release-8.0.37-29 for review purposes only. This needs to be changed to release-8.0.38-30 once this branch is available.

@percona-ysorokin
Copy link
Collaborator Author

@kamil-holubicki Just to let you know, as it was your patch originally.

Copy link
Contributor

@dlenev dlenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@percona-ysorokin percona-ysorokin changed the base branch from release-8.0.37-29 to release-8.0.39-30 August 27, 2024 12:14
@percona-ysorokin
Copy link
Collaborator Author

Re-created as #5383 with GCA in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants