Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS-9328: Fix for sporadic rpl.rpl_json test failures. #5429

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

dlenev
Copy link
Contributor

@dlenev dlenev commented Sep 16, 2024

Results from JSON_OBJECTAGG aggregate function can depend on the order in which rows are returned by SELECT clause, in cases when it can get duplicate values as its "key" argument. However, such order is not guaranteed in general case and can, for example, depend on the order in which tables are joined.

rpl.rpl_json test has failed sporadically, when one of its queries that uses JSON_OBJECTAGG in such an ambigous context, was executed using different join order.

This fix solves the problem by enforcing fixed join order for this query.

Results from JSON_OBJECTAGG aggregate function can depend on the order
in which rows are returned by SELECT clause, in cases when it can get
duplicate values as its "key" argument. However, such order is not
guaranteed in general case and can, for example, depend on the order
in which tables are joined.

rpl.rpl_json test has failed sporadically, when one of its queries
that uses JSON_OBJECTAGG in such an ambigous context, was executed
using different join order.

This fix solves the problem by enforcing fixed join order for this
query.
Copy link
Collaborator

@percona-ysorokin percona-ysorokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlenev dlenev merged commit 807561c into percona:release-8.4.2-2 Sep 16, 2024
9 of 11 checks passed
@dlenev dlenev deleted the ps-9328-rpl_json-fix branch September 16, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants