PS-9470 : Code refresh for PS 8.4.3 - post merge MTR fix (fixed auth_… #5465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sec.acl_tables_row_locking test). auth_sec.acl_tables_row_locking test failed due to different order of rows returned by queries on P_S.data_locks, which was caused by Upstream's change to P_S.data_locks implementation as part of fix for Bug#36302624 "performance_schema.data_lock_waits is generated with O(N^3) complexity". See: mysql/mysql-server@96ccd8d The probelm is not specific to PS and affects Upstream as well. This patch fixes the problem by adding ORDER BY clause to query on P_S.data_locks run by this test, ensuring stable order of result rows, similarly how it is done in some other tests querying this P_S table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sec.acl_tables_row_locking test).
auth_sec.acl_tables_row_locking test failed due to different order of rows returned by queries on P_S.data_locks, which was caused by Upstream's change to P_S.data_locks implementation as part of fix for Bug#36302624 "performance_schema.data_lock_waits is generated with O(N^3) complexity".
See: mysql/mysql-server@96ccd8d
The probelm is not specific to PS and affects Upstream as well.
This patch fixes the problem by adding ORDER BY clause to query on P_S.data_locks run by this test, ensuring stable order of result rows, similarly how it is done in some other tests querying this P_S table.