PMM-5058 Update node_exporter-like metrics. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Dec 10, 2019
| }, | ||
| }, | ||
| }) | ||
| // TODO |
There was a problem hiding this comment.
sessions/sessions_test.go:57: Line contains TODO/BUG/FIXME: "TODO" (from godox)
1 task
golangcibot
reviewed
Dec 10, 2019
| @@ -11,34 +14,53 @@ import ( | |||
| ) | |||
|
|
|||
| //nolint:lll | |||
| func readJSON(t *testing.T, file string) []byte { | |||
There was a problem hiding this comment.
func readJSON is unused (from unused)
| return bytes.TrimSpace(b) | ||
| } | ||
|
|
||
| func readMetrics(t *testing.T, file string) []string { |
There was a problem hiding this comment.
func readMetrics is unused (from unused)
|
|
||
| b, err := ioutil.ReadFile(filepath.Join("testdata", file)) //nolint:gosec | ||
| require.NoError(t, err) | ||
| return bytes.TrimSpace(b) |
There was a problem hiding this comment.
return statements should not be cuddled if block has more than two lines (from wsl)
|
|
||
| b, err := ioutil.ReadFile(filepath.Join("testdata", file)) //nolint:gosec | ||
| require.NoError(t, err) | ||
| return strings.Split(string(bytes.TrimSpace(b)), "\n") |
There was a problem hiding this comment.
return statements should not be cuddled if block has more than two lines (from wsl)
| m := prometheus.MustNewConstMetric(desc, prometheus.CounterValue, float64(*s.ReadKb*1024), labelValues...) | ||
| res = append(res, m) | ||
| } | ||
| if s.WriteKb != nil { | ||
| desc := prometheus.NewDesc("node_disk_bytes_written", "The total number of bytes written successfully.", labelKeys, constLabels) | ||
| desc := prometheus.NewDesc("node_disk_written_bytes_total", "The total number of bytes written successfully.", labelKeys, constLabels) |
| res = append(res, prometheus.MustNewConstMetric(desc, prometheus.GaugeValue, float64((s.Total-s.Used)*1024), labelValues...)) | ||
| desc = prometheus.NewDesc("node_filesystem_avail", "Filesystem space available to non-root users in bytes.", labelKeys, constLabels) | ||
| desc = prometheus.NewDesc("node_filesystem_avail_bytes", "Filesystem space available to non-root users in bytes.", labelKeys, constLabels) |
golangcibot
reviewed
Dec 10, 2019
| @@ -10,35 +14,51 @@ import ( | |||
| "github.com/stretchr/testify/require" | |||
| ) | |||
|
|
|||
| //nolint:lll | |||
| var golden = flag.Bool("golden", false, "update golden files") | |||
There was a problem hiding this comment.
golden is a global variable (from gochecknoglobals)
AlekSi
changed the title
BupycHuk
approved these changes
Dec 11, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node_memory_XXX=>node_memory_XXX_bytesnode_disk_XXX=>node_disk_XXX_bytesnode_filesystem_XXX=>node_filesystem_XXX_bytes