feat: send domInfoSha when posting comparisons

percy · May 25, 2023 · 2591a74 · 2591a74
1 parent d365dc3
commit 2591a74
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/client/src/client.js b/packages/client/src/client.js
@@ -366,7 +366,7 @@ export class PercyClient {
     return snapshot;
   }
 
-  async createComparison(snapshotId, { tag, tiles = [], externalDebugUrl, ignoredElementsData } = {}) {
+  async createComparison(snapshotId, { tag, tiles = [], externalDebugUrl, domInfoSha, ignoredElementsData } = {}) {
     validateId('snapshot', snapshotId);
 
     this.log.debug(`Creating comparision: ${tag.name}...`);
@@ -386,7 +386,8 @@ export class PercyClient {
         type: 'comparisons',
         attributes: {
           'external-debug-url': externalDebugUrl || null,
-          'ignore-elements-data': ignoredElementsData || null
+          'ignore-elements-data': ignoredElementsData || null,
+          'dom-info-sha': domInfoSha || null,
         },
         relationships: {
           tag: {

diff --git a/packages/webdriver-utils/src/providers/genericProvider.js b/packages/webdriver-utils/src/providers/genericProvider.js
@@ -50,7 +50,10 @@ export default class GenericProvider {
       tag,
       tiles,
       // TODO: Fetch this one for bs automate, check appium sdk
+      // TODO: Need to update external debug url validation in api
       externalDebugUrl: this.debugUrl,
+      // TODO: pass actual dom info sha
+      domInfoSha: null,
       environmentInfo: ENV_INFO,
       clientInfo: CLIENT_INFO
     };