Skip to content

Commit

Permalink
Update messaging for storing logs (#1690)
Browse files Browse the repository at this point in the history
  • Loading branch information
chinmay-browserstack authored Aug 14, 2024
1 parent a2f1abd commit cde4108
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion packages/cli-exec/test/exec.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ describe('percy exec', () => {
'[percy] Suggestion: Try using percy snapshot command to take snapshots',
'[percy] Refer to the below Doc Links for the same',
'[percy] * https://www.browserstack.com/docs/percy/take-percy-snapshots/',
'[percy] Notice: Percy collects CI logs for service improvement, stored for 30 days. Opt-out anytime with export PERCY_CLIENT_ERROR_LOGS=false'
'[percy] Notice: Percy collects CI logs to improve service and enhance your experience. These logs help us debug issues and provide insights on your dashboards, making it easier to optimize the product experience. Logs are stored securely for 30 days. You can opt out anytime with export PERCY_CLIENT_ERROR_LOGS=false, but keeping this enabled helps us offer the best support and features.'
]));

expect(logger.stdout).toEqual(jasmine.arrayContaining([
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-exec/test/start.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ describe('percy exec:start', () => {
});

expect(logger.stderr).toEqual(jasmine.arrayContaining([
'[percy] Notice: Percy collects CI logs for service improvement, stored for 30 days. Opt-out anytime with export PERCY_CLIENT_ERROR_LOGS=false',
'[percy] Notice: Percy collects CI logs to improve service and enhance your experience. These logs help us debug issues and provide insights on your dashboards, making it easier to optimize the product experience. Logs are stored securely for 30 days. You can opt out anytime with export PERCY_CLIENT_ERROR_LOGS=false, but keeping this enabled helps us offer the best support and features.',
'[percy] Error: Percy is already running or the port 5338 is in use',
'[percy] Error: Percy is already running or the port 5338 is in use'
]));
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/percy.js
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ export class Percy {

try {
if (process.env.PERCY_CLIENT_ERROR_LOGS !== 'false') {
this.log.warn('Notice: Percy collects CI logs for service improvement, stored for 30 days. Opt-out anytime with export PERCY_CLIENT_ERROR_LOGS=false');
this.log.warn('Notice: Percy collects CI logs to improve service and enhance your experience. These logs help us debug issues and provide insights on your dashboards, making it easier to optimize the product experience. Logs are stored securely for 30 days. You can opt out anytime with export PERCY_CLIENT_ERROR_LOGS=false, but keeping this enabled helps us offer the best support and features.');
}
// Not awaiting proxy check as this can be asyncronous when not enabled
const detectProxy = detectSystemProxyAndLog(this.config.percy.useSystemProxy);
Expand Down
2 changes: 1 addition & 1 deletion packages/core/test/percy.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ describe('Percy', () => {
await expectAsync(percy.start()).toBeResolved();

expect(logger.stderr).toEqual([
'[percy] Notice: Percy collects CI logs for service improvement, stored for 30 days. Opt-out anytime with export PERCY_CLIENT_ERROR_LOGS=false'
'[percy] Notice: Percy collects CI logs to improve service and enhance your experience. These logs help us debug issues and provide insights on your dashboards, making it easier to optimize the product experience. Logs are stored securely for 30 days. You can opt out anytime with export PERCY_CLIENT_ERROR_LOGS=false, but keeping this enabled helps us offer the best support and features.'
]);
expect(logger.stdout).toEqual([
'[percy] Percy has started!'
Expand Down

0 comments on commit cde4108

Please sign in to comment.