Fixed tests

percy · Oct 23, 2024 · eff6096 · eff6096
1 parent dd158bc
commit eff6096
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 13 deletions.
diff --git a/packages/cli-build/test/id.test.js b/packages/cli-build/test/id.test.js
@@ -29,7 +29,8 @@ describe('percy build:id', () => {
 
     expect(logger.stderr).toEqual([]);
     expect(logger.stdout).toEqual(['123']);
-    expect(percyServer.requests).toEqual([['/percy/healthcheck']]);
+    expect(percyServer.requests.length).toEqual(1);
+    expect(percyServer.requests[0][0]).toEqual('/percy/healthcheck');
   });
 
   it('can call the /percy/healthcheck endpoint at an alternate port', async () => {
@@ -40,7 +41,8 @@ describe('percy build:id', () => {
 
     expect(logger.stderr).toEqual([]);
     expect(logger.stdout).toEqual(['456']);
-    expect(percyServer.requests).toEqual([['/percy/healthcheck']]);
+    expect(percyServer.requests.length).toEqual(1);
+    expect(percyServer.requests[0][0]).toEqual('/percy/healthcheck');
   });
 
   it('logs an error when the endpoint errors', async () => {

diff --git a/packages/cli-exec/test/ping.test.js b/packages/cli-exec/test/ping.test.js
@@ -34,7 +34,8 @@ describe('percy exec:ping', () => {
 
     expect(logger.stderr).toEqual([]);
     expect(logger.stdout).toEqual(['[percy] Percy is running']);
-    expect(percyServer.requests).toEqual([['/percy/healthcheck']]);
+    expect(percyServer.requests.length).toEqual(1);
+    expect(percyServer.requests[0][0]).toEqual('/percy/healthcheck');
   });
 
   it('can ping /percy/healthcheck at an alternate port', async () => {
@@ -46,7 +47,8 @@ describe('percy exec:ping', () => {
 
     expect(logger.stderr).toEqual([]);
     expect(logger.stdout).toEqual(['[percy] Percy is running']);
-    expect(percyServer.requests).toEqual([['/percy/healthcheck']]);
+    expect(percyServer.requests.length).toEqual(1);
+    expect(percyServer.requests[0][0]).toEqual('/percy/healthcheck');
   });
 
   it('logs an error when the endpoint errors', async () => {

diff --git a/packages/cli-exec/test/stop.test.js b/packages/cli-exec/test/stop.test.js
@@ -24,10 +24,9 @@ describe('percy exec:stop', () => {
 
     await stop();
 
-    expect(percyServer.requests).toEqual([
-      ['/percy/stop'],
-      ['/percy/healthcheck']
-    ]);
+    expect(percyServer.requests.length).toEqual(2);
+    expect(percyServer.requests[0][0]).toEqual('/percy/stop');
+    expect(percyServer.requests[1][0]).toEqual('/percy/healthcheck');
 
     expect(logger.stderr).toEqual([]);
     expect(logger.stdout).toEqual(['[percy] Percy has stopped']);
@@ -54,10 +53,9 @@ describe('percy exec:stop', () => {
 
     await stop(['--port=4567']);
 
-    expect(percyServer.requests).toEqual([
-      ['/percy/stop'],
-      ['/percy/healthcheck']
-    ]);
+    expect(percyServer.requests.length).toEqual(2);
+    expect(percyServer.requests[0][0]).toEqual('/percy/stop');
+    expect(percyServer.requests[1][0]).toEqual('/percy/healthcheck');
 
     expect(logger.stderr).toEqual([]);
     expect(logger.stdout).toEqual(['[percy] Percy has stopped']);

diff --git a/packages/core/src/network.js b/packages/core/src/network.js
@@ -414,7 +414,7 @@ async function sendResponseResource(network, request, session) {
 
 // Make a new request with Node based on a network request
 async function makeDirectRequest(network, request, session) {
-  const { cookies = [] } = await session.send('Network.getCookies', { urls: [request.url] });
+  const { cookies } = await session.send('Network.getCookies', { urls: [request.url] });
 
   let headers = {
     ...request.headers,