Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.28.2 introduces a bug causing our CI to fail due to bad requests #1568

Closed
Osseta opened this issue Apr 10, 2024 · 3 comments
Closed

V1.28.2 introduces a bug causing our CI to fail due to bad requests #1568

Osseta opened this issue Apr 10, 2024 · 3 comments
Labels
🐛 bug Something isn't working

Comments

@Osseta
Copy link

Osseta commented Apr 10, 2024

The problem

V1.28.2 causes requests for assets that do not exists to be sent to our application server which causes the server to raise an error and our test suite ro fail.

This only occurs when we request a percy snapshot.

The error looks like

    ActionController::RoutingError:
       No route matches [GET] "/__serialized__/_fo6qheiye.svg+xml"
     # ./lib/static_asset_middleware.rb:14:in `call'

It appears related to the introduction serializeBase64() of in commit fe2a

Environment

  • Node version:
  • @percy/cli version: 1.28.2
  • Version of Percy SDK you’re using: percy-capybara 5.0.0
  • OS version: Linux & MacOS
  • Type of shell command-line [interface]: bash & zsh

Debug logs

debug.log

@Osseta Osseta changed the title V1.28.2 introduces a bug causing out CI to fail V1.28.2 introduces a bug causing our CI to fail due to bad requests Apr 10, 2024
@prklm10 prklm10 added the 🐛 bug Something isn't working label Apr 10, 2024
@prklm10
Copy link
Contributor

prklm10 commented Apr 10, 2024

We will look into this.

@pankaj443
Copy link
Contributor

Hey @Osseta , a fix for this is released in the latest version, 1.28.3

@Osseta
Copy link
Author

Osseta commented Apr 15, 2024

I can confirm that release 1.28.3 resolves the issue in our CI pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants