Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 127.0.0.1 with render.percy.local #1571

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Replace 127.0.0.1 with render.percy.local #1571

merged 3 commits into from
Apr 12, 2024

Conversation

pankaj443
Copy link
Contributor

@pankaj443 pankaj443 commented Apr 10, 2024

Github Issue: #1568
We can across an issue where when server defined with 127.0.0.1 instead of localhost on rails application was throwing unknown route error.
This was due to replacement of Url was not happening for it. Ficed this to replace domain with render.percy.local in both cases.

@pankaj443 pankaj443 requested a review from a team as a code owner April 10, 2024 08:28
@pankaj443 pankaj443 merged commit ad54098 into master Apr 12, 2024
36 checks passed
@pankaj443 pankaj443 deleted the PER_3088 branch April 12, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants