-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for legacy protocol #1323
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
export default class NormalizeData { | ||
osRollUp(os) { | ||
if (os.toLowerCase().startsWith('win')) { | ||
return 'Windows'; | ||
} else if (os.toLowerCase().startsWith('mac')) { | ||
return 'OS X'; | ||
} else if (os.toLowerCase().includes('iphone') || os.toLowerCase().startsWith('ios')) { | ||
return 'iOS'; | ||
} else if (os.toLowerCase().startsWith('android')) { | ||
return 'Android'; | ||
} | ||
return os; | ||
} | ||
|
||
browserRollUp(browserName, device) { | ||
if (device) { | ||
if (browserName?.toLowerCase().includes('chrome')) { | ||
return 'chrome'; | ||
} else if ((browserName?.toLowerCase().includes('iphone') || | ||
browserName?.toLowerCase().includes('ipad'))) { | ||
return 'safari'; | ||
} | ||
} | ||
return browserName; | ||
} | ||
|
||
browserVersionRollUp(browserVersion, deviceName, device) { | ||
if (device) { | ||
// return `${this.osRollUp(os)} ${osVersion?.split('.')[0]}`; | ||
return deviceName; | ||
} | ||
return browserVersion?.split('.')[0]; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didnt understand why are we using deviceName for browserVersionRollUp ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reason being that in case of devices we don't really get the
browserVersion
properly. In capabilities we are getting thebrowserVersion
as theiphone
ordevice_name
itself in certain devices. Responses differ when using different appium and selenium Version. And from the UI perspective to keep it consistent we moved it to keepdevice_name
this ensures no UI change is required and nothing is breaking.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, then can we just rename function to
browserVersionOrDeviceNameRollup
and add the comment on top ? [ the same comment as what you have explained above