♻ Adjust how the browser download script determines executable path #150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This takes the guesswork out of determining the browser executable path. The current guesswork is accurate for Chromium, but when this script is utilized to download other browsers, the executable location can be difficult to determine based on the filename alone. For example, the archive for Firefox on Linux is
firefox 73.0.tar.bz2
and when getting the executable path it guessesfirefox 73.0.tar/firefox
even though the actual archive unzips tofirefox/firefox
.By removing the guesswork and being explicit, we can avoid OS/Browser archive name inconsistencies.