Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻ Adjust how the browser download script determines executable path #150

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

wwilsman
Copy link
Contributor

What is this?

This takes the guesswork out of determining the browser executable path. The current guesswork is accurate for Chromium, but when this script is utilized to download other browsers, the executable location can be difficult to determine based on the filename alone. For example, the archive for Firefox on Linux is firefox 73.0.tar.bz2 and when getting the executable path it guesses firefox 73.0.tar/firefox even though the actual archive unzips to firefox/firefox.

By removing the guesswork and being explicit, we can avoid OS/Browser archive name inconsistencies.

@wwilsman wwilsman requested a review from Robdel12 January 26, 2021 20:10
@wwilsman wwilsman added the 🧹 maintenance General maintenance label Jan 26, 2021
Copy link
Contributor

@Robdel12 Robdel12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏁

@wwilsman wwilsman merged commit cd01203 into master Jan 26, 2021
@wwilsman wwilsman deleted the ww/adjust-browser-install-script branch January 26, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 maintenance General maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants