⬆ Upgrade Chromium 78 to 87 #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scripts can no longer navigate to the chrome crash screen to trigger a crash. Instead, private properties were un-privated so the test can reach in to trigger a crash.
wwilsman
force-pushed
the
ww/upgrade-chromium
branch
from
5894344 to
06a1a13
Compare
Robdel12
approved these changes
Feb 1, 2021
| "clean": "rm -rf packages/**/{dist,.nyc_output,coverage,oclif.manifest.json}", | ||
| "release-notes": "./scripts/release-notes", |
| @@ -8,6 +9,8 @@ export default class Network { | |||
| #intercepts = new Map(); | |||
| #authentications = new Set(); | |||
|
|
|||
| log = logger('core:network'); | |||
There was a problem hiding this comment.
fuuuuuuuttttttttttuuureeeeeeeeeeeee
|
|
Fix your bootleg ⬆️ emoji? 😂 |
No, it just gets corrected in some places automatically 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This updates the version of Chromium downloaded and used by asset discovery to Chrome 87.0.4280, which matches the next version that will be used in Percy's own rendering environment.
With this specific version of Chromium, the revisions are varied across all platforms. To make finding these revisions easier than the manual process, I automated it with a script. I also removed the old release-notes script since this repo uses a release-drafting action.
If authenticated with GitHub, the script could be modified to search a range of several versions to find a close match that has only one revision across all platforms. It could also be improved with GitHub's GraphQL API to search for the tag in a single query rather than paginating all tags for the Chromium repo. But that can be a future improvement for the next update.
Two tests needed to be updated:
chrome://crash. Scripts are no longer allowed to navigate to URLs which crash the page, so a few private properties were un-privated in order to trigger a page crash by issuing aPage.crashcommand over CDP.While fixing test 2, I updated some discovery logs as well