-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Discovery retry support + fixed a race condition in network handling #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prklm10
approved these changes
Feb 22, 2024
ninadbstack
force-pushed
the
race-condition-in-network
branch
from
March 7, 2024 13:48
46701d8
to
d0e18bc
Compare
ninadbstack
force-pushed
the
race-condition-in-network
branch
from
March 7, 2024 14:02
d0e18bc
to
e524b6a
Compare
ninadbstack
changed the title
Race condition in network handling
✨ Discovery retry support + fixed a race condition in network handling
Mar 7, 2024
prklm10
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🍍
This was referenced Jun 3, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General snapshot discovery retry mechanism
Context:
Changes:
discovery
section of config toretry
discovery. For now itsfalse
by defaultretry
is set to true we attempt discovery upto 3 times, printing a log line whenever its retrying the snapshotretry
option on per snapshot basis by passing{discovery: {retry: true}}
in per snapshot options.Race condition in discovery for certain cases:
Context:
#requests
but we only getloadingFinished
event for one of them. -> other request remains stuck and we throw idle timeout.pending
state. But for these requests we in general do getresponseReceived
callback, but dont getloadingFinished
.Changes:
finishedUrls
set. Whenever we look foridle
we now ignore all the urls which are successfully finished at least once before.