✨ Upgrade to Node 12 #161
Merged
✨ Upgrade to Node 12 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since eslint-standard 16, the plugin is no longer required
I think so, I dig that. I don't know if there are any other standards for enforcing that |
|
Can we change anything about our build? (Are there less things polyfilled from 10 to 12?) |
Robdel12
approved these changes
Feb 2, 2021
Specified with an .nvmrc file Release and Lint workflows were also updated to reflect a dev environment while the Test and Typecheck workflows are kept at Node 12 to test Maintenance LTS compatibility.
Babel config was updated so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Node 10 will be EOL on April 30th. We can prepare early by specifying a minimum Node version and running our tests on the next maintenance LTS version, Node 12.
Questions
Should we update the other CI actions to use the current Active LTS, Node 14? I would also encourage development using the Active LTS so we can be prepared next year when Node 12 is EOL and we repeat this process again. Shall I create an
.nvmrcfile specifying Node 14? Are there any other formats or universal way I'm forgetting about to convey development should happen using a specific Node version?