➖ Remove path-type dependency #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dependency has many small helpers based on two single sync and async helpers. In both places we use this dependency, we only use it to check if a filepath is a directory synchronously. This is done by the depdendency wrapping fs.statSync().isDirectory() in a try-catch to catch ENOENT errors. In both places we use this helper, we are already wrapping them in a try-catch, so we can swap out this dependency entirely with the native method. However this dep will still exist in our tree, as I believe cosmiconfig depends on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This dependency has many small helpers based on two single sync and async helpers. In both places we use this dependency, we only use it to check if a filepath is a directory synchronously. This is done by the depdendency wrapping
fs.statSync().isDirectory()in a try-catch to catchENOENTerrors. In both places we use this helper, we are already wrapping calls in a try-catch, so we can swap out this dependency entirely with the native method.However this dependency will still exist in our tree, as I believe
cosmiconfigdepends on it.