-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect and modify invalid URL characters #1664
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this-is-shivamsingh
changed the title
feat: added invalid URL detection for snapshot & network urls
Detect and modify invalid URL characters
Jul 18, 2024
ninadbstack
reviewed
Jul 19, 2024
ninadbstack
reviewed
Jul 19, 2024
ninadbstack
reviewed
Jul 19, 2024
ninadbstack
reviewed
Jul 19, 2024
ninadbstack
reviewed
Jul 19, 2024
feat: moved logging and trycatch handling to utils.js chore: Updated error/warning message for invalid URL's
…Url in snapshot.js
ninadbstack
approved these changes
Jul 22, 2024
rishigupta1599
approved these changes
Jul 22, 2024
this-is-shivamsingh
added a commit
that referenced
this pull request
Aug 2, 2024
This reverts commit a555427.
this-is-shivamsingh
added a commit
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://browserstack.atlassian.net/browse/PPLT-3177
Issues:
bad URI errors
.Changes:
encodeURI
, this encodes the invalid/unsupported characters with their respective encoding characters.Eg:
decodeURI
first makes the URL to come in original form and thenencodeURI
, converts every unsupported character to there respective encoded character. This avoids encoding of already encoded characters.<space>
, %5B -> [ and so on.Testing:
# $ % !, * <space> [ ] {}
etc, that are generally unsupported by browsers.