-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAC file support via PERCY_PAC_FILE_URL env var #1784
Merged
ninadbstack
merged 7 commits into
percy:pac-file-support
from
khushhalm:pac-file-support
Nov 19, 2024
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7c0d8d2
PAC file support via PERCY_PAC_FILE_PATH env var
khushhalm 51351fb
Added pac-proxy-agent lib as dependency
khushhalm 222536e
typo fixes
khushhalm 2317844
PR comments addressed
khushhalm e2934fe
Moved pac-proxy-agent lib dependency to percy client instead of main …
khushhalm 68d3885
Resolved conflicts
khushhalm a271439
Merge branch 'master' into pac-file-support
khushhalm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing specs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I do this later? Can create a Jira so that this is not missed.
Need to share the custom build to GM by today to test PAC support.
Or if it blocker can I take help from someone in Percy team for this? Since need to test couple of other things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we dont merge anything without specs on CLI - I can release alpha version from branch without specs if you want - so that its not merged to master