Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added newer options in interface for typescript #1802

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Added newer options in interface for typescript #1802

merged 1 commit into from
Nov 28, 2024

Conversation

ninadbstack
Copy link
Contributor

@ninadbstack ninadbstack commented Nov 28, 2024 •
edited
Loading

  • We had missed some options in types definitions for typescript sdks
  • Added missing options - updated order to be same as validator [ order doesn't matter its only for readability ]

@ninadbstack ninadbstack requested a review from a team as a code owner November 28, 2024 05:59
@ninadbstack ninadbstack changed the title Added newer options in interface Added newer options in interface for typescript Nov 28, 2024
@ninadbstack ninadbstack added the ✨ enhancement New feature or request label Nov 28, 2024
@ninadbstack ninadbstack merged commit c3490c8 into master Nov 28, 2024
36 checks passed
@ninadbstack ninadbstack deleted the update-typescript-interfaces branch November 28, 2024 06:10
@ninadbstack ninadbstack added the 🐛 bug Something isn't working label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prklm10 prklm10 prklm10 approved these changes

@pankaj443 pankaj443 Awaiting requested review from pankaj443 pankaj443 is a code owner automatically assigned from percy/percy-product-reviewers

Assignees
No one assigned
Labels
🐛 bug Something isn't working ✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ninadbstack @prklm10