Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Improve plugin autoloading #183

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Conversation

wwilsman
Copy link
Contributor

@wwilsman wwilsman commented Feb 9, 2021

What is this?

When the CLI is linked or eventually distributed outside of NPM, it might not always reside within a project or global node_modules. In these cases, it should autoload plugins from within its own node_modules. This will enable linking plugins to the linked CLI and also allow future iterations to install plugins into the CLIs own node_modules.

This is labeled as a bug although it doesn't necessarily fix anything because it would be one if we distributed the CLI outside of NPM.

When the CLI is linked or eventually distributed outside of NPM, it might not always reside within a
project or global node_modules. In these cases, it should autload plugins from within it's own
node_modules. This will enable linking plugins to the linked CLI and also allow future iterations to
install plugins into own node_modules.
@wwilsman wwilsman added the 🐛 bug Something isn't working label Feb 9, 2021
@wwilsman wwilsman requested a review from Robdel12 February 9, 2021 21:21
Copy link
Contributor

@Robdel12 Robdel12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏁

@wwilsman wwilsman merged commit 737e57c into master Feb 9, 2021
@wwilsman wwilsman deleted the ww/improve-plugin-autoload branch February 9, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants