🐛 Catch autoload directory errors

packages/cli/index.js

@@ -23,7 +23,7 @@ function findPlugins(dir, pattern, registered) {
     }
 
     return plugins;
-  }, []));
+  }, []), () => []);
 }
 
 // automatically register/unregister plugins by altering the CLI's package.json within node_modules

packages/cli/test/helpers.js

@@ -4,7 +4,7 @@ import mockRequire from 'mock-require';
 export function pluginMocker() {
   let pkgPath = path.resolve(__dirname, '../package.json');
 
-  let mock = ({ plugins, packages }) => {
+  let mock = ({ plugins, packages = {} }) => {
     for (let [name, dep] of Object.entries(plugins)) {
       if (dep) mock.pkg.dependencies[name] = true;
       mock.pkg.oclif.plugins.push(name);
@@ -15,29 +15,28 @@ export function pluginMocker() {
       if (name.startsWith('@percy')) dir = path.resolve(dir, '@percy');
       let dirname = name.replace('@percy', '');
 
-      mock.dir[dir].push(dirname);
+      (mock.dir[dir] ||= []).push(dirname);
       mockRequire(`${dir}/${dirname}/package.json`, plugin ? (
         { name, oclif: { bin: 'percy' } }
       ) : { name });
     }
   };
 
+  mock.dir = {};
   mock.pkg = {
     oclif: { plugins: [] },
     dependencies: {}
   };
 
-  mock.dir = {
-    [path.resolve(__dirname, '../node_modules/@percy')]: [],
-    [path.resolve(__dirname, '../node_modules')]: []
-  };
-
   mockRequire(pkgPath, mock.pkg);
   mockRequire('fs', {
     ...require('fs'),
 
     promises: {
-      readdir: async dir => mock.dir[dir],
+      readdir: async dir => {
+        if (mock.dir[dir]) return mock.dir[dir];
+        throw new Error('ENOENT');
+      },
       writeFile: async (path, contents) => {
         if (path === pkgPath) {
           mock.pkg = JSON.parse(contents);

packages/cli/test/index.test.js

@@ -77,4 +77,19 @@ describe('Plugin auto-registration', () => {
       '@percy/cli-other'
     ]);
   });
+
+  it('ignores missing node_modules directory', async () => {
+    // not mocking packages will not create mock directories
+    mock({
+      plugins: {
+        '@percy/cli-exec': true
+      }
+    });
+
+    await run();
+
+    expect(mock.pkg.oclif.plugins).toEqual([
+      '@percy/cli-exec'
+    ]);
+  });
 });