Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Catch undefined globalThis in bundles #234

Merged
merged 1 commit into from
Mar 10, 2021
Merged

🐛 Catch undefined globalThis in bundles #234

merged 1 commit into from
Mar 10, 2021

Conversation

wwilsman
Copy link
Contributor

What is this?

In response to #232, I forgot that globalThis is also referenced in build bundles.

@wwilsman wwilsman added the 🐛 bug Something isn't working label Mar 10, 2021
@wwilsman wwilsman requested a review from Robdel12 March 10, 2021 23:24
@wwilsman wwilsman enabled auto-merge (squash) March 10, 2021 23:24
Robdel12
Robdel12 approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@Robdel12 Robdel12 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏁 I am lol'ing approving

@wwilsman wwilsman merged commit f925efb into master Mar 10, 2021
@wwilsman wwilsman deleted the ww/catch-globalthis-bundle branch March 10, 2021 23:34
samarsault pushed a commit that referenced this pull request Mar 3, 2023
@dependabot-preview
build(deps-dev): Bump tslint from 6.1.2 to 6.1.3 (#234)
172863d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robdel12 Robdel12 Robdel12 approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwilsman @Robdel12