🐛 Expose version header for CORS #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwilsman
force-pushed
the
ww/fix-remote-logger-handler-cleanup
branch
from
b1a48ea to
9a5e59c
Compare
wwilsman
force-pushed
the
ww/cors-exposed-headers
branch
from
834f6a5 to
68b99b9
Compare
samarsault
pushed a commit
that referenced
this pull request
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
With most responses, all headers in the request response are included in the response object. In browsers however, the
Access-Control-Expose-Headersheader is strictly respected and if that header does not exist, or the desired header is not defined within it, the response object will not contain all response headers.Adding this header will allow SDKs within browsers to access the version header exposed by the local Percy server API.
Depends on #252, #253, & #254