-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Browserify @percy/sdk-utils #265
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
660d6f6
✨ Browserify @percy/sdk-utils
wwilsman 2071a1f
♻ Split up and refactor @percy/sdk-utils
wwilsman d8fffdd
🔧 Allow registering scripts as karma hooks
wwilsman c233149
✅ Update @percy/sdk-utils tests and bundle test helpers
wwilsman 471948c
📝 Update @percy/sdk-utils readme
wwilsman cb79888
📝 Add config property to sdk-utils docs
wwilsman 221d910
📝 Update inline comment
wwilsman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,4 @@ oclif.manifest.json | |
.DS_Store | ||
.local-chromium | ||
packages/logger/test/client.js | ||
packages/sdk-utils/test/client.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
import logger from '@percy/logger'; | ||
import percy from './percy-info'; | ||
import request from './request'; | ||
import isPercyEnabled from './percy-enabled'; | ||
import fetchPercyDOM from './percy-dom'; | ||
import postSnapshot from './post-snapshot'; | ||
|
||
export { | ||
logger, | ||
percy, | ||
request, | ||
isPercyEnabled, | ||
fetchPercyDOM, | ||
postSnapshot | ||
}; | ||
|
||
export default { | ||
logger, | ||
percy, | ||
request, | ||
isPercyEnabled, | ||
fetchPercyDOM, | ||
postSnapshot | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import percy from './percy-info'; | ||
import request from './request'; | ||
|
||
// Fetch and cache the @percy/dom script | ||
export default async function fetchPercyDOM() { | ||
if (percy.domScript == null) { | ||
let response = await request('/percy/dom.js'); | ||
percy.domScript = response.body; | ||
} | ||
|
||
return percy.domScript; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this stance you're taking here. NO SEMI'S?!