Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The
@percy/core
package manages chromium version on its own when no executables provided, so there is no versions mismatch possible in this scenario. However, when thePERCY_BROWSER_EXECUTABLE
env var is set to point to a chromium executable it becomes difficult to manage the chromium version and keep it aligned with the ones that the library is supposed to work with. Especially, when the dependency definition inpackage.json
file is set like:In this PR
Expose chromium versions to be able to assert that the local one fits the requirement. For example:
By exposing the chromium version, we can provide a guarantee that the versions are matching along with the ability to upgrade the library independently while the local and required versions are the same.
cc @joscha