🐛 Account for logger websocket synchrony #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwilsman
force-pushed
the
ww/logger-socket-synchrony
branch
6 times, most recently
from
f432d6e to
3ea0014
Compare
wwilsman
force-pushed
the
ww/logger-socket-synchrony
branch
from
3ea0014 to
3cc4083
Compare
|
Weird. Looks like automerge kicked in even though there were failing checks |
|
Not marked required are they? |
|
No they are required. It must've been a race condition where the checks showed as passing before previously passing checks reran and failed |
|
Broken test was a silly windows issue fixed with 3c94d7e |
samarsault
pushed a commit
that referenced
this pull request
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Sometimes, WebSocket errors can come from the constructor itself which is defined outside the scope of the logger. Rather than having extra error handling, we can have the logger accept a socket creator function and wrap it with the existing error handling.
Usage of the
remotemethod was updated in@percy/sdk-utilsas well as other tests.