🐛 Fix AMD bundle #290
Merged
🐛 Fix AMD bundle #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
AMD bundles have two syntaxes:
define(id, deps[], factory)anddefine(deps[], factory)(filename becomes the ID). We were inadvertently combing the syntaxes intodefine([id], factory).While our incorrect syntax is technically valid (circular dep on itself), we had another compounding issue. We were using
pkg.namefor the ID even when the package contains multiple bundles (like for test helpers).While requiring the AMD bundle in Ember SDK tests, this compounded issue caused the test helpers to re-require the main package bundle which caused duplicate bundles to be included causing the test helpers to use outdated references.
This PR simply removes AMD deps from our bundles since our bundles do not actually contain external deps.