Code review feedback

percy · Oct 30, 2019 · 85160e8 · 85160e8
1 parent 63590ee
commit 85160e8
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/test/utils/logger.test.ts b/test/utils/logger.test.ts
@@ -9,21 +9,22 @@ describe('logger utils', () => {
 
     afterEach(() => {
       if (filesToCleanUp) {
-        filesToCleanUp.forEach((file: string) => existsSync(`${process.cwd()}/${file}`) && unlinkSync(`${process.cwd()}/${file}`))
+        filesToCleanUp.forEach((file: string) => {
+          let filePath = `${process.cwd()}/${file}`;
+          if (!existsSync(filePath)) { return; }
+
+          unlinkSync(filePath)
+        })
       }
     })
 
     it('does not leak memory', async () => {
-      const output = await captureStdErr(async () => {
-        await new Promise((resolve) => {
-          new Array(600).fill(0).forEach((item, index) => {
-            const fileName = `test-file-${index}`
-            createFileLogger(fileName)
-            filesToCleanUp.push(fileName)
-          })
-
-          resolve()
-        })
+      const output = await captureStdErr(() => {
+        for (let index = 0; index < 600; index++) {
+          const fileName = `test-file-${index}`
+          createFileLogger(fileName)
+          filesToCleanUp.push(fileName)
+        }
       })
 
       expect(output).to.equal('')