Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Introduce cross-spawn for cross platform commands (#175)
This PR introduces cross platform spawning of commands. Will close #174. The problem is Windows users need to use the `exec` command like this: ``` $ percy exec -- cypress.cmd run ``` If they don't, we can't spawn their original test command. What's happening is nodes `spawn` ignores windows `PATHEXT` which is kinda like `$PATH` & that means `spawn` only works on Windows for `.exe` files. See: - nodejs/node-v0.x-archive#2318 - bcoe/awesome-cross-platform-nodejs#26 Tested here: https://github.com/percy/example-percy-cypress/compare/rd/test-cross-platform The first commit uses `cross_spawn` and successfully starts Cypress. The second commit uses `0.4.0` of agent and fails to start Cypress.
- Loading branch information