Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty canvas elements are serialized as broken images #533

Open
wwilsman opened this issue Jul 8, 2020 · 0 comments
Open

Empty canvas elements are serialized as broken images #533

wwilsman opened this issue Jul 8, 2020 · 0 comments

Comments

@wwilsman
Copy link
Contributor

wwilsman commented Jul 8, 2020

Given an empty canvas element, it will be serialized as the following DOM:

<img style="max-width: 100%" class="percy-canvas-image" src="data:," data-percy-canvas-serialized="true">

Which results in this screenshot:

image

In these instances, it's probably best if the canvas is not serialized and left alone to avoid broken images
@Robdel12 Robdel12 self-assigned this Jul 8, 2020
bitjson added a commit to bitauth/bitauth-ide that referenced this issue Jul 23, 2020
@bitjson
ci: hide empty canvas element for percy
a5f5f98 
A bug currently causes empty canvas elements to display a broken image icon in Percy's Chrome
screenshots: percy/percy-agent#533. This hides the broken image icon.
@Robdel12 Robdel12 removed their assignment Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Robdel12 @wwilsman