build: Introduce rollup to bundle percy-agent.js for browsers
#124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djones
reviewed
Apr 5, 2019
This is to resolve the error where winston was being being included in various webpack bundles. We change the `main` entry point of the `@percy/agent` package so only the file that's ready for a browser is bundled. Then we transpile that file fully with babel and rollup so their webpack config isn't looking to compile it too. This solves percy/percy-cypress#58 fully.
Most of the errors stemmed from us using the logger (which is a node logger) in our SDK utils, which is apart of our main export of the package. This would cause bundlers to try and bundle that code and fail because it couldn't find FS
That will be handled in a different PR and we're changing the way SDKs import that file
Robdel12
force-pushed
the
rd/introduce-rollup
branch
from
20ca9f8 to
ecdb395
Compare
Robdel12
changed the title
percy-agent.js & remove loggerpercy-agent.js for browsers
djones
reviewed
Apr 5, 2019
| "@types/sinon-chai": "^3.2.0", | ||
| "@semantic-release/git": "^7.0.8", |
djones
reviewed
Apr 5, 2019
| @@ -109,7 +118,7 @@ | |||
| "repository": "percy/percy-agent", | |||
| "scripts": { | |||
| "build": "npm run clean && rm -rf dist && tsc && npm run build-client", | |||
| "build-client": "mkdir -p dist/public && browserify src/percy-agent-client/index.ts -p [ tsify --noImplicitAny ] --standalone PercyAgent > dist/public/percy-agent.js", | |||
| "build-client": "rollup -c", | |||
|
Really curious what |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This PR introduces the rollup bundler so we can properly bundle the
percy-agent.jsfile. Currently we transpile it with browserify but we don't bundle all of the code together into a single file. Since we're injecting this code into browsers it would be best to transpile it and then pull it together into a single file (so there are norequiresor anything of that nature in the file).This also introduces babel, which will soon be replacing all of browserify in this project. The community has essentially settled on babel as the ecosystem to transpile future JS code to JS that can run in the browser today.