fix: Static service Wait for network idle #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been seeing a lot of errors like: ``` Error: Execution context was destroyed, most likely because of a navigation. ``` This happens because we try to start altering the page (by injecting our JS) before everything is settled down. This change won't promise the page has actually loaded (that's very hard to determine) but it will wait for most network requests to resolve before trying do anything.
|
If this still brings up troubles, we could use https://github.com/percy/percy-agent/blob/master/src/utils/wait-for-network-idle.ts next |
|
@djones OHH very nice, that would be a great next step |
djones
pushed a commit
that referenced
this pull request
Jul 2, 2019
## [0.8.1](v0.8.0...v0.8.1) (2019-07-02) ### Bug Fixes * Static service wait for network idle ([#270](#270)) ([7d438d2](7d438d2))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
I've been seeing a lot of errors like:
This happens because we try to start altering the page (by injecting our JS) before everything is settled down. This change won't promise the page has actually loaded (that's very hard to determine) but it will wait for most network requests to resolve before trying do anything.