fix: Trim whitespace from CSS ownerNode innerText #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we might incorrectly assume this style element has valid CSS content. In the future we might want to regex check the content?
wwilsman
approved these changes
Oct 29, 2019
djones
pushed a commit
that referenced
this pull request
Oct 29, 2019
## [0.19.4](v0.19.3...v0.19.4) (2019-10-29) ### Bug Fixes * Trim whitespace from CSS ownerNode innerText ([#406](#406)) ([5a4f830](5a4f830))
This was referenced Nov 5, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
If the
styleelement has innerText that's just line returns, we will incorrectly assume that it has valid CSS content.This PR will strip whitespace from the ownerNodes innerText.