fix: skip caching empty resources #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skip caching empty resources (browser resource hints)
Robdel12
approved these changes
Jan 21, 2020
| @@ -78,7 +78,7 @@ describe('Integration test', () => { | |||
| expect(domSnapshot).contains('badssl.com') | |||
| }) | |||
|
|
|||
| it('snapshots a complex website with responsive images', async () => { | |||
| it.skip('snapshots a complex website with responsive images', async () => { | |||
There was a problem hiding this comment.
I think we can just delete this test tbh. We have a responsive image test further down that isn't a live site.
We have a locally controlled test for responsive images, the live sites only cause pain since we cannot maintain them.
wwilsman
force-pushed
the
blake-newman-blake.newman/skip-caching-empty-resources
branch
from
349a2b1 to
fc7f908
Compare
wwilsman
deleted the
blake-newman-blake.newman/skip-caching-empty-resources
branch
djones
pushed a commit
that referenced
this pull request
Jan 21, 2020
## [0.20.12](v0.20.11...v0.20.12) (2020-01-21) ### Bug Fixes * skip caching empty resources ([#458](#458)) ([c2cb769](c2cb769))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Builds onto #437 by adding tests
Approach
Added a unit test for this since our acceptance tests might be a little flakey due to slow startup times.
This suite was adjusted to account for now requiring a couple other response methods.
Also in this test suite, I replaced instances of
() { return 'foo' }with() => 'foo'except where we explicitly need to referencethis.Skipped a live site test due to the response being very slow. We have a ticket to remove (and replace if necessary) these live tests, but that should be in another PR. Skipping the failing one for now rather than increasing the timeout to 20 seconds.