Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clamp image dimensions to min and max for snapshot width and minHeight options #460

Merged
merged 1 commit into from
Jan 31, 2020
Merged

fix: clamp image dimensions to min and max for snapshot width and minHeight options #460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/services/image-snapshot-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,9 @@ export default class ImageSnapshotService extends PercyClientService {
): Promise<any> {
return this.percyClient.createSnapshot(this.buildId, resources, {
name,
widths: [width],
minimumHeight: height,
// clamp between 10px - 2000px
widths: [Math.max(10, Math.min(width, 2000))],
minimumHeight: Math.max(10, Math.min(height, 2000)),
clientInfo: 'percy-upload',
}).then(async (response: any) => {
await this.percyClient.uploadMissingResources(this.buildId, response, resources)
Expand Down