fix(🐛): upgrade puppeteer to try fixing page crashes #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It isn't gauranteed that this will prevent page crashes, but it's worth a shot. If this doesn't fix the issue, then we might need to consider downgrading back to Puppeteer 2.x
Robdel12
approved these changes
Jul 31, 2020
There was a problem hiding this comment.
🏁 I'm hopeful, but skeptical. I have a feeling the memory issues are coming with the version of Chrome rather than the version of Puppeteer API (probably not a CDP issue, but an issue with the browser).
ANYWAYS, 🤞
Related issue/comment: puppeteer/puppeteer#1321 (comment)
The revisions of Chromium included with puppeteer since 5.0.0 seem to have issues with woff2 requests. Need to investegate further before upgrading to the latest version to see if it's a breaking change or a bug.
djones
pushed a commit
that referenced
this pull request
Aug 3, 2020
# [1.0.0](v0.27.2...v1.0.0) (2020-08-03) ### Bug Fixes * **🐛:** upgrade puppeteer to try fixing page crashes ([#539](#539)) ([cf33170](cf33170)) ### BREAKING CHANGES * **🐛:** or a bug.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been a few reports of Puppeteer page crashes that might possibly be related to a recent Puppeteer upgrade. Rather than downgrade back to 2.x again, let's first try upgrading to 5.x 🤞
Update: The revisions of Chromium included with puppeteer since 5.0.0 seem to have issues with woff2 requests. Need to investigate further before upgrading to the latest version to see if it's a breaking change or a bug. For now, puppeteer has been pinned to 5.0.0.