Point to healthcheck inside of the dist folder always
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like `cy.exec` takes care of any cross platform issues. All tests pass -- I'm curious what this might be missing? `require` isn't available in the browser and neither is `path`. Seems like `cy.exec` also resolves the path properly.
|
Closing this. We’re going to implement a health check CLI command in agent to avoid all of these path issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This removes the healthcheck dance that uses
requireandpath, which aren't available in the browser. It wasn't quite transpiling properly (#69), so if this doesn't actually work well, we should look at making changes to how this SDK is distributed.It looks like
cy.exectakes care of any cross platform issues. All tests pass -- I'm curious what this might be missing? Seems likecy.execalso resolves the path properly. Before merge I'd like to cut a beta and have some folks try it out that had the healthcheck issues in #61. Just to be 100% sure we're not regressing (since we haven't been able to replicate)Open question
Is this healthcheck really needed? I'm curious what it's meant to do? Is it to provide helpful logging for when a snapshot fails? How does it fail if the server isn't available?
cy.request()doesn't fail the cypress test build and we can.catchany errors from it and provide nice logs from there I believe.It might be that this pain can just go away with that. Curious to hear thoughts on this.