Skip to content

Commit

Permalink
Ignore Element key name change (#221)
Browse files Browse the repository at this point in the history
* Added logic for ignore region

* added test case

* Added validation in tests

* Possible concurrent thread fix 1

* Possible concurrent thread fix 2

* Possible concurrent thread fix 3

* Possible concurrent thread fix 4

* Possible concurrent thread fix 5

* Fix ignore region logic
  • Loading branch information
chinmay-browserstack authored Jun 21, 2023
1 parent 3b78466 commit 752a877
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/main/java/io/percy/selenium/Percy.java
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,8 @@ public void screenshot(String name, Map<String, Object> options) throws Unsuppor

if (options.containsKey(ignoreElementKey)) {
List<String> ignoreElementIds = getElementIdFromElement((List<RemoteWebElement>) options.get(ignoreElementKey));
options.replace(ignoreElementKey, ignoreElementIds);
options.remove(ignoreElementKey);
options.put("ignore_region_elements", ignoreElementIds);
}

// Build a JSON object to POST back to the agent node process
Expand Down

0 comments on commit 752a877

Please sign in to comment.